net-wireless/easyroam-desktop: fix issues

- removed trailing [./] from DESCRIPTION & HOMEPAGE
- introduced MY_PN to enhance readability
- removed patch in favour of a simple sed
  - it had the wrong name either way
- RDEPEND:
  - sort
  - add missing zlib, gdk-pixbuf & at-spi2-core
  - specify GTK+'s SLOT
- rework QA variables to be more specific

Closes: https://bugs.gentoo.org/946620
Closes: https://bugs.gentoo.org/950639
Signed-off-by: Filip Kobierski <fkobi@pm.me>

net-wireless/easyroam-desktop/easyroam-desktop-1.4.3-r1.ebuild

@@ -5,41 +5,44 @@ EAPI=8
 
 inherit unpacker xdg-utils
 
-DESCRIPTION="Easily connect your device to eduroam®."
-HOMEPAGE="https://www.easyroam.de/"
-SRC_URI="https://packages.easyroam.de/repos/easyroam-desktop/pool/main/e/easyroam-desktop/easyroam_connect_desktop-${PV}+${PV}-linux.deb"
-
-QA_FLAGS_IGNORED=".*"
+MY_PN="easyroam_connect_desktop"
 
+DESCRIPTION="Easily connect your device to eduroam®"
+HOMEPAGE="https://www.easyroam.de"
+SRC_URI="https://packages.easyroam.de/repos/easyroam-desktop/pool/main/e/easyroam-desktop/${MY_PN}-${PV}+${PV}-linux.deb"
 S="${WORKDIR}"
 
 LICENSE="all-rights-reserved"
 SLOT="0"
 KEYWORDS="-* ~amd64"
 
-PATCHES=(
-	# easyroam desktop ships a malformed .desktop file, this patch fixes that
-	"${FILESDIR}"/0001-fix-desktop-file.patch
-)
-
 RDEPEND="
-	dev-libs/glib
-	x11-libs/gtk+
-	x11-libs/pango
-	x11-libs/cairo
-	media-libs/harfbuzz
+	app-accessibility/at-spi2-core
 	app-crypt/libsecret
+	dev-libs/glib
+	media-libs/harfbuzz
 	net-misc/networkmanager
-	net-libs/webkit-gtk:4.1[keyring]
-	net-libs/libsoup:3.0
 	net-libs/glib-networking
+	net-libs/libsoup:3.0
+	net-libs/webkit-gtk:4.1[keyring]
+	sys-libs/zlib
+	x11-libs/cairo
+	x11-libs/gdk-pixbuf:2
+	x11-libs/gtk+:3
+	x11-libs/pango
 "
 DEPEND="${RDEPEND}"
 
+QA_PREBUILT="
+	/usr/share/${MY_PN}/${MY_PN}
+	/usr/share/${MY_PN}/lib/*
+"
 src_prepare() {
+	# correct the version
+	sed -i "s/${PV}/1.0/g" "${S}"/usr/share/applications/${MY_PN}.desktop
 	sed -i \
-		"s/Exec=easyroam_connect_desktop/Exec=\/usr\/share\/easyroam_connect_desktop\/easyroam_connect_desktop/" \
-		"${S}/usr/share/applications/easyroam_connect_desktop.desktop"
+		"s/Exec=${MY_PN}/Exec=\/usr\/share\/${MY_PN}\/${MY_PN}/" \
+		"${S}/usr/share/applications/${MY_PN}.desktop"
 	default
 }
 

net-wireless/easyroam-desktop/files/0001-fix-desktop-file.patch

@@ -1,18 +0,0 @@
-diff --git a/usr/share/applications/easyroam_connect_desktop.desktop b/usr/share/applications/easyroam_connect_desktop.desktop
-index af29159..58ff457 100644
---- a/usr/share/applications/easyroam_connect_desktop.desktop
-+++ b/usr/share/applications/easyroam_connect_desktop.desktop
-@@ -1,10 +1,10 @@
- [Desktop Entry]
- Type=Application
--Version=1.4.3
-+Version=1.0
- Name=Easyroam
- GenericName=wifi profile installer
- Icon=easyroam_connect_desktop
- Exec=/usr/share/easyroam_connect_desktop/easyroam_connect_desktop %U
- Categories=Utility;
- Keywords=easyroam;eduroam;Easyroam;Eduroam;
--StartupNotify=true
-\ No newline at end of file
-+StartupNotify=true